Matter Sensor: Add modular profile supports for AQS #2082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 67 files 435 suites 0s ⏱️ Results for commit 632d75c. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 632d75c |
ctowns
force-pushed
the
modular-profiles-matter-sensor
branch
2 times, most recently
from
271a839 to
83f4407
Compare
hcarter-775
reviewed
Apr 18, 2025
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Apr 18, 2025
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Apr 18, 2025
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Apr 18, 2025
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
ctowns
force-pushed
the
modular-profiles-matter-sensor
branch
from
83f4407 to
91e95e5
Compare
ctowns
force-pushed
the
modular-profiles-matter-sensor
branch
3 times, most recently
from
da8c20f to
6a42641
Compare
ctowns
force-pushed
the
modular-profiles-matter-sensor
branch
from
6a42641 to
ecf0a67
Compare
ctowns
force-pushed
the
modular-profiles-matter-sensor
branch
from
ffd6bb3 to
c08a758
Compare
| match_modular_profile(driver, device) | ||
| else | ||
| match_profile_switch(driver, device) | ||
|
|
There was a problem hiding this comment.
nit there's a extra line here
hcarter-775
reviewed
May 16, 2025
| end | ||
|
|
||
| local function do_configure(driver, device) | ||
| -- we have to read the unit before reports of values will do anything |
There was a problem hiding this comment.
Suggested change
| -- we have to read the unit before reports of values will do anything | |
| -- we have to read the unit before reports of values will do anything |
hcarter-775
reviewed
May 16, 2025
hcarter-775
reviewed
May 16, 2025
| version: 1 | ||
| categories: | ||
| - name: AirQualityDetector | ||
| preferences: |
There was a problem hiding this comment.
We might need two versions of this profile, one without the preferences, since temperatureMeasurement and relativeHumidityMeasurement are optional
| local matter_air_quality_sensor_handler = { | ||
| NAME = "matter-air-quality-sensor", | ||
| lifecycle_handlers = { | ||
| init = device_init, | ||
| doConfigure = do_configure | ||
| doConfigure = do_configure, | ||
| infoChanged = info_changed, |
There was a problem hiding this comment.
Should we implement a driverSwitched handler and call match_modular_profile from it?
|
|
||
| local clusters = require "st.matter.clusters" | ||
|
|
||
| clusters.AirQuality = require "AirQuality" |
There was a problem hiding this comment.
Is there a reason you're testing with the embedded clusters rather than from the lua libs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests